Replace de.atextor:turtle-formatter with cool.rdf:cool-rdf-formatter#2995
Open
fkleedorfer wants to merge 11 commits into
Open
Replace de.atextor:turtle-formatter with cool.rdf:cool-rdf-formatter#2995fkleedorfer wants to merge 11 commits into
fkleedorfer wants to merge 11 commits into
Conversation
Contributor
Author
|
Pending cool-rdf/cool-rdf#66 |
Contributor
Author
|
Fixes issue #2996 |
fkleedorfer
marked this pull request as ready for review
July 17, 2026 13:56
Contributor
Author
|
Ready for review - and I think I need help with these failing tests |
- Add 'rdf' to the special tests list in gradle/special-tests.gradle - Tag RdfFormatterTest class with @tag("rdf") to exclude from standard build matrix - RDF tests can still be run separately with ./gradlew testRdf on Java 25+ This resolves UnsupportedClassVersionError (class file version 69.0) when running tests with Java 17, 21, and 24 in the CI pipeline.
Contributor
Author
|
@nedtwigg I think this is ready for review now |
# Conflicts: # plugin-maven/CHANGES.md
The PR excluded RDF tests from CI by adding 'rdf' to the special-tests exclusion list. Remove it and drop @tag("rdf") so these tests run with the rest of the suite.
nedtwigg
enabled auto-merge
July 22, 2026 17:02
Member
|
I made a few commits, take a look at each. Now that the test are running, they are failing because the new formatter requires Java 25+. One of two things needs to happen:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.
Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.
After creating the PR, please add a commit that adds a bullet-point under the
[Unreleased]section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:If your change only affects a build plugin, and not the lib, then you only need to update the
plugin-foo/CHANGES.mdfor that plugin.If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update
CHANGES.mdfor both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.This makes it easier for the maintainers to quickly release your changes :)